flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #2463: [FLINK-4538][FLINK-4348] ResourceManager slot allo...
Date Tue, 06 Sep 2016 14:55:23 GMT
Github user tillrohrmann commented on a diff in the pull request:

    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
    @@ -52,15 +58,28 @@
      * </ul>
     public class ResourceManager extends RpcEndpoint<ResourceManagerGateway> {
    -	private final Map<JobMasterGateway, InstanceID> jobMasterGateways;
    +	private final Logger LOG = LoggerFactory.getLogger(getClass());
    --- End diff --
    But then this field should probably marked as `protected` instead of `private`.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message