flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] flink pull request #2425: FLINK-3930 Added shared secret based authorization...
Date Fri, 02 Sep 2016 09:41:37 GMT
Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2425#discussion_r77320247
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java ---
    @@ -426,4 +440,11 @@ void unregisterConnection(BlobServerConnection conn) {
     		}
     	}
     
    +	/* Secure cookie to authenticate */
    +	@Override
    +	public String getSecureCookie() { return secureCookie; }
    +
    +	/* Flag to indicate if service level authentication is enabled or not */
    +	public boolean isSecurityEnabled() { return secureCookie != null; }
    --- End diff --
    
    Okay, I see. In the constructor you are checking that the secureCookie is set if security
is enabled.
    
    Then its okay to leave it as is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message