flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request #2450: [FLINK-4458] Replace ForkableFlinkMiniCluster by L...
Date Thu, 01 Sep 2016 14:10:46 GMT
Github user StephanEwen commented on a diff in the pull request:

    --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/minicluster/FlinkMiniCluster.scala
    @@ -69,7 +69,7 @@ abstract class FlinkMiniCluster(
    -  val configuration = generateConfiguration(userConfiguration)
    +  protected val _configuration = generateConfiguration(userConfiguration)
    --- End diff --
    Why the underscore here?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message