Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 018D0200B73 for ; Mon, 29 Aug 2016 19:45:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id F40D6160AB8; Mon, 29 Aug 2016 17:45:21 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6E30F160A89 for ; Mon, 29 Aug 2016 19:45:21 +0200 (CEST) Received: (qmail 91002 invoked by uid 500); 29 Aug 2016 17:45:20 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 90985 invoked by uid 99); 29 Aug 2016 17:45:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Aug 2016 17:45:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 86A9D2C0031 for ; Mon, 29 Aug 2016 17:45:20 +0000 (UTC) Date: Mon, 29 Aug 2016 17:45:20 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-4528) Mark runAsync and scheduleAsync methods protected MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 29 Aug 2016 17:45:22 -0000 [ https://issues.apache.org/jira/browse/FLINK-4528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446540#comment-15446540 ] ASF GitHub Bot commented on FLINK-4528: --------------------------------------- Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2436 I think that the `RpcEndpoint` should keep the control over which components have access to its main thread and which not. Furthermore, limiting the access to protected does not prohibit other components to use the main thread execution context. The difference is simply that the `TaskExecutor` has to actively give the context to the component instead of the component taking it. > Mark runAsync and scheduleAsync methods protected > ------------------------------------------------- > > Key: FLINK-4528 > URL: https://issues.apache.org/jira/browse/FLINK-4528 > Project: Flink > Issue Type: Sub-task > Components: Distributed Coordination > Reporter: Till Rohrmann > Assignee: Till Rohrmann > Priority: Minor > > Currently, the {{runAsync}} and {{scheduleAsync}} methods of the {{RpcEndpoint}} are marked as public. I think that these methods should be protected since nobody should be able to influence the internal state of an {{RpcEndpoint}} from the outside via these methods. -- This message was sent by Atlassian JIRA (v6.3.4#6332)