Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Thu, 25 Aug 2016 18:18:22 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.12999846.1472080025000.412419.1472149102029@Atlassian.JIRA>
In-Reply-To: <JIRA.12999846.1472080025000@Atlassian.JIRA>
References: <JIRA.12999846.1472080025000@Atlassian.JIRA> <JIRA.12999846.1472080025949@arcas>
Subject: [jira] [Commented] (FLINK-4482) numUnsuccessfulCheckpointsTriggers
 is accessed without holding triggerLock
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 25 Aug 2016 18:18:25 -0000


    [ https://issues.apache.org/jira/browse/FLINK-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15437383#comment-15437383 ] 

ASF GitHub Bot commented on FLINK-4482:
---------------------------------------

GitHub user tedyu opened a pull request:

    https://github.com/apache/flink/pull/2421

    FLINK-4482 numUnsuccessfulCheckpointsTriggers is accessed without holding triggerLock

    Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your changes.
    
    - [ ] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [ ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tedyu/flink master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2421.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2421
    
----
commit 2021f4790715ecb762dbb23438bf0b2b2755845e
Author: tedyu <yuzhihong@gmail.com>
Date:   2016-08-25T18:11:44Z

    FLINK-4482 numUnsuccessfulCheckpointsTriggers is accessed without holding triggerLock

----


> numUnsuccessfulCheckpointsTriggers is accessed without holding triggerLock
> --------------------------------------------------------------------------
>
>                 Key: FLINK-4482
>                 URL: https://issues.apache.org/jira/browse/FLINK-4482
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>
> In CheckpointCoordinator#stopCheckpointScheduler() :
> {code}
>     synchronized (lock) {
> ...
>       numUnsuccessfulCheckpointsTriggers = 0;
> {code}
> triggerLock is not held in the above operation.
> See comment for triggerLock earlier in triggerCheckpoint():
> {code}
>     // we lock with a special lock to make sure that trigger requests do not overtake each other.
>     // this is not done with the coordinator-wide lock, because the 'checkpointIdCounter'
>     // may issue blocking operations. Using a different lock than teh coordinator-wide lock,
>     // we avoid blocking the processing of 'acknowledge/decline' messages during that time.
>     synchronized (triggerLock) {
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)