Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Sat, 13 Aug 2016 15:11:20 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.12996646.1470928839000.298714.1471101080435@Atlassian.JIRA>
In-Reply-To: <JIRA.12996646.1470928839000@Atlassian.JIRA>
References: <JIRA.12996646.1470928839000@Atlassian.JIRA> <JIRA.12996646.1470928839008@arcas>
Subject: [jira] [Commented] (FLINK-4383) Check parameters for
 serializability before sending a remote RpcInvocation message
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sat, 13 Aug 2016 15:11:22 -0000


    [ https://issues.apache.org/jira/browse/FLINK-4383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15419958#comment-15419958 ] 

ASF GitHub Bot commented on FLINK-4383:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2365#discussion_r74688005
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaInvocationHandler.java ---
    @@ -25,33 +25,42 @@
     import org.apache.flink.runtime.rpc.MainThreadExecutor;
     import org.apache.flink.runtime.rpc.RpcTimeout;
     import org.apache.flink.runtime.rpc.akka.messages.CallAsync;
    +import org.apache.flink.runtime.rpc.akka.messages.LocalRpcInvocation;
    +import org.apache.flink.runtime.rpc.akka.messages.RemoteRpcInvocation;
     import org.apache.flink.runtime.rpc.akka.messages.RpcInvocation;
     import org.apache.flink.runtime.rpc.akka.messages.RunAsync;
     import org.apache.flink.util.Preconditions;
    +import org.apache.log4j.Logger;
     import scala.concurrent.Await;
     import scala.concurrent.Future;
     import scala.concurrent.duration.FiniteDuration;
     
    +import java.io.IOException;
     import java.lang.annotation.Annotation;
     import java.lang.reflect.InvocationHandler;
     import java.lang.reflect.Method;
     import java.util.BitSet;
     import java.util.concurrent.Callable;
     
     /**
    - * Invocation handler to be used with a {@link AkkaRpcActor}. The invocation handler wraps the
    - * rpc in a {@link RpcInvocation} message and then sends it to the {@link AkkaRpcActor} where it is
    + * Invocation handler to be used with an {@link AkkaRpcActor}. The invocation handler wraps the
    + * rpc in a {@link LocalRpcInvocation} message and then sends it to the {@link AkkaRpcActor} where it is
      * executed.
      */
     class AkkaInvocationHandler implements InvocationHandler, AkkaGateway, MainThreadExecutor {
    +	private static final Logger LOG = Logger.getLogger(AkkaInvocationHandler.class);
    +
     	private final ActorRef rpcServer;
    --- End diff --
    
    How about renaming this to `rpcEndpoint`. That way it would line up with the naming in other places.


> Check parameters for serializability before sending a remote RpcInvocation message
> ----------------------------------------------------------------------------------
>
>                 Key: FLINK-4383
>                 URL: https://issues.apache.org/jira/browse/FLINK-4383
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>
> Before sending a remote {{RpcInvocation}} message we should check that the rpc arguments are serializable. If not we should eagerly fail with an appropriate exception message.
> If we don't do this, then Akka will silently fail serializing the message without telling the user.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)