Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Mon, 15 Aug 2016 16:58:20 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.12996210.1470820814000.306728.1471280300569@Atlassian.JIRA>
In-Reply-To: <JIRA.12996210.1470820814000@Atlassian.JIRA>
References: <JIRA.12996210.1470820814000@Atlassian.JIRA> <JIRA.12996210.1470820814628@arcas>
Subject: [jira] [Commented] (FLINK-4355) Implement TaskManager side of
 registration at ResourceManager
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 15 Aug 2016 16:58:22 -0000


    [ https://issues.apache.org/jira/browse/FLINK-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15421264#comment-15421264 ] 

ASF GitHub Bot commented on FLINK-4355:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2353#discussion_r74793706
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutorToResourceManagerConnection.java ---
    @@ -0,0 +1,80 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.rpc.taskexecutor;
    +
    +import org.apache.flink.runtime.rpc.resourcemanager.ResourceManagerGateway;
    +
    +import java.util.UUID;
    +
    +import static org.apache.flink.util.Preconditions.checkNotNull;
    +
    +public class TaskExecutorToResourceManagerConnection {
    --- End diff --
    
    Agreed, let's factor it out as a common utility do that as part of the next component that needs it.


> Implement TaskManager side of registration at ResourceManager
> -------------------------------------------------------------
>
>                 Key: FLINK-4355
>                 URL: https://issues.apache.org/jira/browse/FLINK-4355
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Cluster Management
>            Reporter: Zhijiang Wang
>            Assignee: Stephan Ewen
>
> If the {{TaskManager}} is unregistered, it should try and register at the {{ResourceManager}} leader. The registration messages are fenced via the {{RmLeaderID}}.
> The ResourceManager may acknowledge the registration (or respond that the TaskManager is AlreadyRegistered) or refuse the registration.
> Upon registration refusal, the TaskManager may have to kill itself.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)