Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Tue, 23 Aug 2016 01:24:22 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.12996192.1470817833000.378394.1471915462205@Atlassian.JIRA>
In-Reply-To: <JIRA.12996192.1470817833000@Atlassian.JIRA>
References: <JIRA.12996192.1470817833000@Atlassian.JIRA> <JIRA.12996192.1470817833969@arcas>
Subject: [jira] [Commented] (FLINK-4348) Implement communication from
 ResourceManager to TaskManager
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 23 Aug 2016 01:24:24 -0000


    [ https://issues.apache.org/jira/browse/FLINK-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431935#comment-15431935 ] 

ASF GitHub Bot commented on FLINK-4348:
---------------------------------------

Github user beyond1920 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2389#discussion_r75789477
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rpc/resourcemanager/ResourceManager.java ---
    @@ -52,18 +61,45 @@
     public class ResourceManager extends RpcEndpoint<ResourceManagerGateway> {
     	private final ExecutionContext executionContext;
     	private final Map<JobMasterGateway, InstanceID> jobMasterGateways;
    +	private final Map<ResourceID, TaskExecutorGateway> taskExecutorGateways;
    +	private final Map<ResourceID, ResourceManagerToTaskExecutorHeartbeatScheduler> heartbeatSchedulers;
    +	private final LeaderElectionService leaderElectionService;
    +	private UUID leaderSessionID;
    +	// TODO private final SlotManager slotManager;
    --- End diff --
    
    SlotManager is doing by kurt. So I marked some TODO here waiting for his PR. It would be removed after SlotManager code committed


> Implement communication from ResourceManager to TaskManager
> -----------------------------------------------------------
>
>                 Key: FLINK-4348
>                 URL: https://issues.apache.org/jira/browse/FLINK-4348
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Cluster Management
>            Reporter: Kurt Young
>            Assignee: zhangjing
>
> There are mainly 3 logics initiated from RM to TM:
> * Heartbeat, RM use heartbeat to sync with TM's slot status
> * SlotRequest, when RM decides to assign slot to JM, should first try to send request to TM for slot. TM can either accept or reject this request.
> * FailureNotify, in some corner cases, TM will be marked as invalid by cluster manager master(e.g. yarn master), but TM itself does not realize. RM should send failure notify to TM and TM can terminate itself


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)