Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Wed, 31 Aug 2016 03:46:21 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.12996148.1470798687000.453834.1472615181464@Atlassian.JIRA>
In-Reply-To: <JIRA.12996148.1470798687000@Atlassian.JIRA>
References: <JIRA.12996148.1470798687000@Atlassian.JIRA> <JIRA.12996148.1470798687259@arcas>
Subject: [jira] [Commented] (FLINK-4347) Implement SlotManager core
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 31 Aug 2016 03:46:23 -0000


    [ https://issues.apache.org/jira/browse/FLINK-4347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15450983#comment-15450983 ] 

ASF GitHub Bot commented on FLINK-4347:
---------------------------------------

Github user KurtYoung commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2388#discussion_r76920351
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/SlotID.java ---
    @@ -75,9 +75,15 @@ public int hashCode() {
     
     	@Override
     	public String toString() {
    -		return "SlotID{" +
    -			"resourceId=" + resourceId +
    -			", slotId=" + slotId +
    -			'}';
    +		return resourceId + "_" + slotId;
    +	}
    +
    +	/**
    +	 * Generate a random slot id.
    +	 *
    +	 * @return A random slot id.
    +	 */
    +	public static SlotID generate() {
    +		return new SlotID(ResourceID.generate(), 0);
    --- End diff --
    
    A SlotID is a identify of the slot which locates in some TaskManager. In current flink's implementaion, we use integer to represent a slot within TM, i think we should make this more explicit.
    For generating a random slot, i think random a resource id which slot is located is enough. (We may have some limitation of the integer else where, like the integer can not be greater than the total slot number of the TM, so i choose 0)


> Implement SlotManager core
> --------------------------
>
>                 Key: FLINK-4347
>                 URL: https://issues.apache.org/jira/browse/FLINK-4347
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Cluster Management
>            Reporter: Kurt Young
>            Assignee: Kurt Young
>
> The slot manager is responsible to maintain the list of slot requests and slot allocations. It allows to request slots from the registered TaskExecutors and issues container allocation requests in case that there are not enough available resources.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)