Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Fri, 5 Aug 2016 14:19:20 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.12993505.1469788105000.234709.1470406760663@Atlassian.JIRA>
In-Reply-To: <JIRA.12993505.1469788105000@Atlassian.JIRA>
References: <JIRA.12993505.1469788105000@Atlassian.JIRA> <JIRA.12993505.1469788105736@arcas>
Subject: [jira] [Commented] (FLINK-4282) Add Offset Parameter to
 WindowAssigners
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 05 Aug 2016 14:19:22 -0000


    [ https://issues.apache.org/jira/browse/FLINK-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15409504#comment-15409504 ] 

ASF GitHub Bot commented on FLINK-4282:
---------------------------------------

Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/2333
  
    IMHO, the offset should not be added to `TimeWindow`. It is only the assigners that would shift the start time/end time of a window. This way, other parts of the code don't need to be aware of offsets, as they are in the current state of this PR.


> Add Offset Parameter to WindowAssigners
> ---------------------------------------
>
>                 Key: FLINK-4282
>                 URL: https://issues.apache.org/jira/browse/FLINK-4282
>             Project: Flink
>          Issue Type: Improvement
>          Components: Streaming
>            Reporter: Aljoscha Krettek
>
> Currently, windows are always aligned to EPOCH, which basically means days are aligned with GMT. This is somewhat problematic for people living in different timezones.
> And offset parameter would allow to adapt the window assigner to the timezone.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)