Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0883C200B68 for ; Fri, 5 Aug 2016 06:55:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 06FBC160AAE; Fri, 5 Aug 2016 04:55:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5084B160AAB for ; Fri, 5 Aug 2016 06:55:21 +0200 (CEST) Received: (qmail 97309 invoked by uid 500); 5 Aug 2016 04:55:20 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 97286 invoked by uid 99); 5 Aug 2016 04:55:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Aug 2016 04:55:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 6C6652C0059 for ; Fri, 5 Aug 2016 04:55:20 +0000 (UTC) Date: Fri, 5 Aug 2016 04:55:20 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-4282) Add Offset Parameter to WindowAssigners MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 05 Aug 2016 04:55:22 -0000 [ https://issues.apache.org/jira/browse/FLINK-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15408877#comment-15408877 ] ASF GitHub Bot commented on FLINK-4282: --------------------------------------- Github user aditivin commented on the issue: https://github.com/apache/flink/pull/2333 Hi, Only the relevant changes are now visible. Pasting the details from the previous pull request (#2331) here: Added offset parameter for the following processing time window assigners: ProcessingTimeSessionWindows SlidingProcessingTimeWindows TumblingProcessingTimeWindows The offset is an optional parameter that can be added while creating these classes, and it can be supplied as a long value or a TimeZone. Test cases for the change are present in WindowAssignerOffsetTest. There are tests for positive, negative and TimeZone offsets for each of the classes. All Travis CI jobs passed. I haven't done it for the event time window assigners yet - I can add that if this is all right. > Add Offset Parameter to WindowAssigners > --------------------------------------- > > Key: FLINK-4282 > URL: https://issues.apache.org/jira/browse/FLINK-4282 > Project: Flink > Issue Type: Improvement > Components: Streaming > Reporter: Aljoscha Krettek > > Currently, windows are always aligned to EPOCH, which basically means days are aligned with GMT. This is somewhat problematic for people living in different timezones. > And offset parameter would allow to adapt the window assigner to the timezone. -- This message was sent by Atlassian JIRA (v6.3.4#6332)