Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Wed, 24 Aug 2016 09:54:20 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.12993343.1469733859000.395279.1472032460778@Atlassian.JIRA>
In-Reply-To: <JIRA.12993343.1469733859000@Atlassian.JIRA>
References: <JIRA.12993343.1469733859000@Atlassian.JIRA> <JIRA.12993343.1469733859512@arcas>
Subject: [jira] [Commented] (FLINK-4278) Unclosed FSDataOutputStream in
 multiple files in the project
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 24 Aug 2016 09:54:22 -0000


    [ https://issues.apache.org/jira/browse/FLINK-4278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15434623#comment-15434623 ] 

ASF GitHub Bot commented on FLINK-4278:
---------------------------------------

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/2403
  
    Sorry, this does not build right now. I would review it once it builds.


> Unclosed FSDataOutputStream in multiple files in the project
> ------------------------------------------------------------
>
>                 Key: FLINK-4278
>                 URL: https://issues.apache.org/jira/browse/FLINK-4278
>             Project: Flink
>          Issue Type: Bug
>    Affects Versions: 1.0.3
>            Reporter: Neelesh Srinivas Salian
>            Assignee: Neelesh Srinivas Salian
>
> After FLINK-4259, I did a check and found that the following files don't have the closing of the FSDataOutputStream.
> The following are the files and the corresponding methods missing the close() 
> 1) FSDataOutputStream.java adding a close method in the abstract class
> 2) FSStateBackend flush() and write() - closing the FSDataOutputStream
> 3) StringWriter.java write()
> 4) FileSystemStateStore putState() -  closing the FSDataOutputStream
> 5) HadoopDataOutputStream.java not too sure if this needs closing.
> 6) FileSystemStateStorageHelper.java store() need closing for both outStream and the ObjectOutputStream
> The options to think would be to either close or use  IOUtils.closeQuietly() 
> Any thoughts?


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)