Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Fri, 19 Aug 2016 08:12:20 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.12993203.1469701585000.352989.1471594340599@Atlassian.JIRA>
In-Reply-To: <JIRA.12993203.1469701585000@Atlassian.JIRA>
References: <JIRA.12993203.1469701585000@Atlassian.JIRA> <JIRA.12993203.1469701585997@arcas>
Subject: [jira] [Commented] (FLINK-4273) Refactor JobClientActor to watch
 already submitted jobs
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 19 Aug 2016 08:12:22 -0000


    [ https://issues.apache.org/jira/browse/FLINK-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427808#comment-15427808 ] 

ASF GitHub Bot commented on FLINK-4273:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2313#discussion_r75442857
  
    --- Diff: flink-tests/src/test/java/org/apache/flink/test/clients/examples/JobRetrievalITCase.java ---
    @@ -0,0 +1,137 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.test.clients.examples;
    +
    +import akka.actor.ActorRef;
    +import akka.actor.ActorSystem;
    +import akka.testkit.JavaTestKit;
    +import org.apache.flink.api.common.JobID;
    +import org.apache.flink.client.program.ClusterClient;
    +import org.apache.flink.client.program.StandaloneClusterClient;
    +import org.apache.flink.runtime.client.JobRetrievalException;
    +import org.apache.flink.configuration.Configuration;
    +import org.apache.flink.runtime.client.JobExecutionException;
    +import org.apache.flink.runtime.jobgraph.JobGraph;
    +import org.apache.flink.runtime.jobgraph.JobVertex;
    +import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
    +import org.apache.flink.runtime.minicluster.FlinkMiniCluster;
    +import org.apache.flink.runtime.testingUtils.TestingJobManagerMessages;
    +import org.apache.flink.test.util.ForkableFlinkMiniCluster;
    +import org.junit.AfterClass;
    +import org.junit.BeforeClass;
    +import org.junit.Test;
    +import scala.collection.Seq;
    +
    +import java.util.concurrent.Semaphore;
    +
    +import static org.junit.Assert.assertNotNull;
    +import static org.junit.Assert.fail;
    +
    +
    +/**
    + * Tests retrieval of a job from a running Flink cluster
    + */
    +public class JobRetrievalITCase {
    --- End diff --
    
    Thanks


> Refactor JobClientActor to watch already submitted jobs 
> --------------------------------------------------------
>
>                 Key: FLINK-4273
>                 URL: https://issues.apache.org/jira/browse/FLINK-4273
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Client
>            Reporter: Maximilian Michels
>            Assignee: Maximilian Michels
>            Priority: Minor
>             Fix For: 1.2.0
>
>
> The JobClientActor assumes that it receives a job, submits it, and waits for the result. This process should be broken up into a submission process and a waiting process which can both be entered independently. This leads to two different entry points:
> 1) submit(job) -> wait
> 2) retrieve(jobID) -> wait


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)