Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E47FB200B61 for ; Tue, 9 Aug 2016 15:33:21 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E311D160AAD; Tue, 9 Aug 2016 13:33:21 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5CC36160A6B for ; Tue, 9 Aug 2016 15:33:21 +0200 (CEST) Received: (qmail 90359 invoked by uid 500); 9 Aug 2016 13:33:20 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 90342 invoked by uid 99); 9 Aug 2016 13:33:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Aug 2016 13:33:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 794482C02A3 for ; Tue, 9 Aug 2016 13:33:20 +0000 (UTC) Date: Tue, 9 Aug 2016 13:33:20 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-4212) Lock PID file when starting daemons MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 09 Aug 2016 13:33:22 -0000 [ https://issues.apache.org/jira/browse/FLINK-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15413516#comment-15413516 ] ASF GitHub Bot commented on FLINK-4212: --------------------------------------- Github user greghogan closed the pull request at: https://github.com/apache/flink/pull/2251 > Lock PID file when starting daemons > ----------------------------------- > > Key: FLINK-4212 > URL: https://issues.apache.org/jira/browse/FLINK-4212 > Project: Flink > Issue Type: Improvement > Components: Startup Shell Scripts > Affects Versions: 1.1.0 > Reporter: Greg Hogan > Assignee: Greg Hogan > > As noted on the mailing list (0), when multiple TaskManagers are started in parallel (using pdsh) there is a race condition on updating the pid: 1) the pid file is first read to parse the process' index, 2) the process is started, and 3) on success the daemon pid is appended to the pid file. > We could use a tool such as {{flock}} to lock on the pid file while starting the Flink daemon. > 0: http://mail-archives.apache.org/mod_mbox/flink-user/201607.mbox/%3CCA%2BssbKXw954Bz_sBRwP6db0FntWyGWzTyP7wJZ5nhOeQnof3kg%40mail.gmail.com%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)