Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: wangzhijiang999 <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-2400-flink@git.apache.org>
In-Reply-To: <git-pr-2400-flink@git.apache.org>
Subject: [GitHub] flink pull request #2400: [FLINK-4363] Implement TaskManager basic startup o...
Content-Type: text/plain
Message-Id: <20160825065521.49CEAE098D@git1-us-west.apache.org>
Date: Thu, 25 Aug 2016 06:55:21 +0000 (UTC)
archived-at: Thu, 25 Aug 2016 06:55:27 -0000

Github user wangzhijiang999 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2400#discussion_r76189334
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutor.java ---
    @@ -94,12 +729,11 @@ public void notifyOfNewResourceManagerLeader(String newLeaderAddress, UUID newLe
     			if (newLeaderAddress != null) {
     				// the resource manager switched to a new leader
     				log.info("ResourceManager leader changed from {} to {}. Registering at new leader.",
    -						resourceManagerConnection.getResourceManagerAddress(), newLeaderAddress);
    --- End diff --
    
    The RPC methods and start method have been put at the top of the class after TaskExecutor constructor.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---