Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: mxm <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-2313-flink@git.apache.org>
In-Reply-To: <git-pr-2313-flink@git.apache.org>
Subject: [GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...
Content-Type: text/plain
Message-Id: <20160823165833.F0F62E020A@git1-us-west.apache.org>
Date: Tue, 23 Aug 2016 16:58:33 +0000 (UTC)
archived-at: Tue, 23 Aug 2016 16:58:40 -0000

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2313#discussion_r75907814
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java ---
    @@ -243,46 +247,46 @@ public static JobExecutionResult awaitJobResult(JobListeningContext listeningCon
     		final JobID jobID = listeningContext.getJobID();
     		final ActorRef jobClientActor = listeningContext.getJobClientActor();
     		final Future<Object> jobSubmissionFuture = listeningContext.getJobResultFuture();
    +		final FiniteDuration askTimeout = listeningContext.getTimeout();
     		// retrieves class loader if necessary
     		final ClassLoader classLoader = listeningContext.getClassLoader();
     
    +		// wait for the future which holds the result to be ready
    +		// ping the JobClientActor from time to time to check if it is still running
     		while (!jobSubmissionFuture.isCompleted()) {
     			try {
    -				Thread.sleep(250);
    -			} catch (InterruptedException e) {
    -				throw new JobExecutionException(jobID, "Interrupted while waiting for execution result.", e);
    -			}
    -
    -			try {
    -				Await.result(
    -					Patterns.ask(
    -						jobClientActor,
    -						JobClientMessages.getPing(),
    -						Timeout.durationToTimeout(AkkaUtils.getDefaultTimeout())),
    -					AkkaUtils.getDefaultTimeout());
    +				Await.ready(jobSubmissionFuture, askTimeout);
     			} catch (Exception e) {
    --- End diff --
    
    Ah, I thought you were commenting on the inner catch block. Yes, it makes sense to catch only `TimeoutException` and `InterruptedException` here for `Await.ready`. `Await.result` actually throws Exception.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---