Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: twalthr <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-2094-flink@git.apache.org>
In-Reply-To: <git-pr-2094-flink@git.apache.org>
Subject: [GitHub] flink pull request #2094: [FLINK-3702] Make FieldAccessors support nested fi...
Content-Type: text/plain
Message-Id: <20160823091153.E26DCE0A3F@git1-us-west.apache.org>
Date: Tue, 23 Aug 2016 09:11:53 +0000 (UTC)
archived-at: Tue, 23 Aug 2016 09:11:58 -0000

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2094#discussion_r75828177
  
    --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/FieldAccessor.java ---
    @@ -0,0 +1,295 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.api.java.typeutils;
    +
    +import org.apache.flink.annotation.PublicEvolving;
    +import org.apache.flink.api.common.operators.Keys;
    +import org.apache.flink.api.common.typeinfo.BasicTypeInfo;
    +import org.apache.flink.api.common.typeinfo.TypeInformation;
    +import org.apache.flink.api.java.tuple.Tuple;
    +import org.apache.flink.api.java.typeutils.runtime.FieldSerializer;
    +
    +import java.io.IOException;
    +import java.io.ObjectInputStream;
    +import java.io.ObjectOutputStream;
    +import java.io.Serializable;
    +import java.lang.reflect.Array;
    +import java.lang.reflect.Field;
    +import java.util.regex.Matcher;
    +import java.util.regex.Pattern;
    +
    +
    +/**
    + * These classes encapsulate the logic of accessing a field specified by the user as either an index
    + * or a field expression string. TypeInformation can also be requested for the field.
    + * The position index might specify a field of a Tuple, an array, or a simple type (only "0th field").
    + *
    + * Field expressions that specify nested fields (e.g. "f1.a.foo") result in nested field accessors.
    + * These penetrate one layer, and then delegate the rest of the work to an "innerAccesor".
    + * (see PojoFieldAccessor, RecursiveTupleFieldAccessor, ProductFieldAccessor)
    + */
    +@PublicEvolving
    +public abstract class FieldAccessor<T, F> implements Serializable {
    +
    +	private static final long serialVersionUID = 1L;
    +
    +	protected TypeInformation fieldType;
    +
    +	/**
    +	 * Gets the TypeInformation for the type of the field.
    +	 * Note: For an array of a primitive type, it returns the corresponding basic type (Integer for int[]).
    +	 */
    +	@SuppressWarnings("unchecked")
    +	public TypeInformation<F> getFieldType() {
    +		return fieldType;
    +	}
    +
    +
    +	/**
    +	 * Gets the value of the field (specified in the constructor) of the given record.
    +	 * @param record
    --- End diff --
    
    My IDE shows a warning here because of missing documentation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---