Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: tillrohrmann <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-2363-flink@git.apache.org>
In-Reply-To: <git-pr-2363-flink@git.apache.org>
Subject: [GitHub] flink pull request #2363: [FLINK-4389] Expose metrics to WebFrontend
Content-Type: text/plain
Message-Id: <20160818164924.5266AE0667@git1-us-west.apache.org>
Date: Thu, 18 Aug 2016 16:49:24 +0000 (UTC)
archived-at: Thu, 18 Aug 2016 16:49:35 -0000

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2363#discussion_r75344971
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/TaskManagerJobMetricGroup.java ---
    @@ -61,9 +58,7 @@ public TaskManagerJobMetricGroup(
     			JobID jobId,
     			@Nullable String jobName) {
     
    -		super(registry, jobId, jobName, scopeFormat.formatScope(parent, jobId, jobName));
    -
    -		this.parent = checkNotNull(parent);
    +		super(registry, checkNotNull(parent), jobId, jobName, scopeFormat.formatScope(parent, jobId, jobName));
    --- End diff --
    
    shouldn't the `checkNotNull` be performed by the super constructor?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---