Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: tillrohrmann <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-2370-flink@git.apache.org>
In-Reply-To: <git-pr-2370-flink@git.apache.org>
Subject: [GitHub] flink pull request #2370: [FLINK-4373] [cluster management] Introduce SlotID...
Content-Type: text/plain
Message-Id: <20160815142923.A00F6E02D4@git1-us-west.apache.org>
Date: Mon, 15 Aug 2016 14:29:23 +0000 (UTC)
archived-at: Mon, 15 Aug 2016 14:29:28 -0000

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2370#discussion_r74769608
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceProfile.java ---
    @@ -0,0 +1,47 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.clusterframework.types;
    +
    +import java.io.Serializable;
    +
    +public class ResourceProfile implements Serializable {
    +
    +	private static final long serialVersionUID = -784900073893060124L;
    +
    +	/** How many cpu cores are needed, use double so we can specify cpu like 0.1 */
    +	private final double cpuCores;
    +
    +	/** How many memory in mb are needed */
    +	private final long memoryInMB;
    +
    +	public ResourceProfile(double cpuCores, long memoryInMB) {
    +		this.cpuCores = cpuCores;
    +		this.memoryInMB = memoryInMB;
    +	}
    +
    +	/**
    +	 * Check whether required resource profile can be matched
    +	 *
    +	 * @param required the required resource profile
    +	 * @return true if the requirement is matched, otherwise false
    +	 */
    +	public boolean matchRequirement(ResourceProfile required) {
    --- End diff --
    
    Maybe we could rename this method to `isMatching` or `isMatchingRequirement`. Starting these kind of methods with a question indicates that it does not change the internal state but checks for a certain condition.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---