flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (FLINK-4534) Lack of synchronization in BucketingSink#restoreState()
Date Tue, 30 Aug 2016 17:37:20 GMT

     [ https://issues.apache.org/jira/browse/FLINK-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Ted Yu updated FLINK-4534:
--------------------------
    Description: 
Iteration over state.bucketStates is protected by synchronization in other methods, except
for the following in restoreState():
{code}
    for (BucketState<T> bucketState : state.bucketStates.values()) {
{code}
w.r.t. bucketState.pendingFilesPerCheckpoint , there is similar issue starting line 752:
{code}
      Set<Long> pastCheckpointIds = bucketState.pendingFilesPerCheckpoint.keySet();
      LOG.debug("Moving pending files to final location on restore.");
      for (Long pastCheckpointId : pastCheckpointIds) {
{code}

  was:
Iteration over state.bucketStates is protected by synchronization in other methods, except
for the following in restoreState():
{code}
    for (BucketState<T> bucketState : state.bucketStates.values()) {
{code}


> Lack of synchronization in BucketingSink#restoreState()
> -------------------------------------------------------
>
>                 Key: FLINK-4534
>                 URL: https://issues.apache.org/jira/browse/FLINK-4534
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ted Yu
>
> Iteration over state.bucketStates is protected by synchronization in other methods, except
for the following in restoreState():
> {code}
>     for (BucketState<T> bucketState : state.bucketStates.values()) {
> {code}
> w.r.t. bucketState.pendingFilesPerCheckpoint , there is similar issue starting line 752:
> {code}
>       Set<Long> pastCheckpointIds = bucketState.pendingFilesPerCheckpoint.keySet();
>       LOG.debug("Moving pending files to final location on restore.");
>       for (Long pastCheckpointId : pastCheckpointIds) {
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message