flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4437) Lock evasion around lastTriggeredCheckpoint may lead to lost updates to related fields
Date Tue, 23 Aug 2016 19:12:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15433417#comment-15433417
] 

ASF GitHub Bot commented on FLINK-4437:
---------------------------------------

GitHub user tedyu opened a pull request:

    https://github.com/apache/flink/pull/2409

    FLINK-4437 Lock evasion around lastTriggeredCheckpoint may lead to lost updates to related
fields

    Thanks for contributing to Apache Flink. Before you open your pull request, please take
the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request.
For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your
changes.
    
    - [ ] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [ ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tedyu/flink master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2409.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2409
    
----
commit 682bf10a70789c76317d460a9c994ebf00f5a516
Author: tedyu <yuzhihong@gmail.com>
Date:   2016-08-23T19:10:03Z

    FLINK-4437 Lock evasion around lastTriggeredCheckpoint may lead to lost updates to related
fields

----


> Lock evasion around lastTriggeredCheckpoint may lead to lost updates to related fields
> --------------------------------------------------------------------------------------
>
>                 Key: FLINK-4437
>                 URL: https://issues.apache.org/jira/browse/FLINK-4437
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ted Yu
>
> In CheckpointCoordinator#triggerCheckpoint():
> {code}
>         // make sure the minimum interval between checkpoints has passed
>         if (lastTriggeredCheckpoint + minPauseBetweenCheckpoints > timestamp) {
> {code}
> If two threads evaluate 'lastTriggeredCheckpoint + minPauseBetweenCheckpoints > timestamp'
in close proximity before lastTriggeredCheckpoint is updated, the two threads may have an
inconsistent view of "lastTriggeredCheckpoint" and updates to fields correlated with "lastTriggeredCheckpoint"
may be lost.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message