flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4435) Replace Guava's VisibleForTesting annotation with Flink's annotation
Date Tue, 23 Aug 2016 06:45:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15432243#comment-15432243
] 

ASF GitHub Bot commented on FLINK-4435:
---------------------------------------

GitHub user wuchong opened a pull request:

    https://github.com/apache/flink/pull/2404

    [FLINK-4435] Replace Guava's VisibleForTesting annotation with Flink's annotation

    Thanks for contributing to Apache Flink. Before you open your pull request, please take
the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request.
For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your
changes.
    
    - [x] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [x] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    
    Replace Guava's VisibleForTesting annotation by Flink's VisibleForTesting annotation.
And add the checkstyle rule to prevent the use of Guava's annotation.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wuchong/flink visible-for-testing

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2404.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2404
    
----
commit 95cca7bbaad6f7984d7075662e7dd809c742f8cf
Author: Jark Wu <wuchong.wc@alibaba-inc.com>
Date:   2016-08-23T06:38:15Z

    [FLINK-4435] Replace Guava's VisibleForTesting annotation with Flink's annotation

----


> Replace Guava's VisibleForTesting annotation with Flink's annotation
> --------------------------------------------------------------------
>
>                 Key: FLINK-4435
>                 URL: https://issues.apache.org/jira/browse/FLINK-4435
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Stephan Ewen
>            Assignee: Jark Wu
>             Fix For: 1.2.0
>
>
> All Guava usages of the {{VisibleForTesting}} annotation should be replaced by Flink's
{{VisibleForTesting}} annotation.
> This should also add a checkstyle rule that prevents the use of Guava's annotation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message