flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4431) Introduce a "VisibleForTesting" annotation
Date Fri, 19 Aug 2016 14:26:21 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428258#comment-15428258

ASF GitHub Bot commented on FLINK-4431:

Github user aljoscha commented on the issue:

    +1, when adding this we should probably replace all uses of the `Guava` version and check
that we don't use it using checkstyle rules. (If our goal is to one day remove our dependency
on `Guava`.)

> Introduce a "VisibleForTesting" annotation
> ------------------------------------------
>                 Key: FLINK-4431
>                 URL: https://issues.apache.org/jira/browse/FLINK-4431
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Stephan Ewen
>            Assignee: Stephan Ewen
>            Priority: Minor
>             Fix For: 1.2.0
> I suggest to introduce a {{VisibleForTesting}} annotation in the {{flink-annotations}}
> Adding this annotation to methods that are really only in place for testing is very useful
feature. Currently, we depend on Guava for that. Having a guava dependency for a documentation
annotation class seems a bit much.

This message was sent by Atlassian JIRA

View raw message