flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4394) RMQSource: The QueueName is not accessible to subclasses
Date Mon, 15 Aug 2016 09:12:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15420752#comment-15420752

ASF GitHub Bot commented on FLINK-4394:

Github user rmetzger commented on the issue:

    I'm going to merge the change once travis gives green light.

> RMQSource: The QueueName is not accessible to subclasses
> --------------------------------------------------------
>                 Key: FLINK-4394
>                 URL: https://issues.apache.org/jira/browse/FLINK-4394
>             Project: Flink
>          Issue Type: Bug
>          Components: Streaming Connectors
>    Affects Versions: 1.1.1
>            Reporter: Dominik Bruhn
>            Assignee: Dominik Bruhn
> In version 1.1.0 we made the RMQSource extensible so that subclasses can configure how
they want their queue for RabbitMQ/AMQP create. The subclasses can override 
> {code}
> 	protected void setupQueue() throws IOException {
> 		channel.queueDeclare(queueName, true, false, false, null);
> 	}
> {code}
> The problem is, that the queueName property is private. So when override the setupQueue
parameter, you don't know what actual queueName was provided. A simple change of the queueName
property to protected fixes this.
> PR will follow

This message was sent by Atlassian JIRA

View raw message