flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4383) Check parameters for serializability before sending a remote RpcInvocation message
Date Fri, 12 Aug 2016 13:48:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15418849#comment-15418849
] 

ASF GitHub Bot commented on FLINK-4383:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/2365

    [FLINK-4383] [rpc] Eagerly serialize remote rpc invocation messages

    This PR introduces an eager serialization for remote rpc invocation messages.
    That way it is possible to check whether the message is serializable and
    whether it exceeds the maximum allowed akka frame size. If either of these
    constraints is violated, a proper exception is thrown instead of simply
    swallowing the exception as Akka does it.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink rpcSerializability

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2365.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2365
    
----
commit 7dcac59723130bd9a77f34cea574f8d7303305f8
Author: Till Rohrmann <trohrmann@apache.org>
Date:   2016-08-12T08:32:30Z

    [FLINK-4383] [rpc] Eagerly serialize remote rpc invocation messages
    
    This PR introduces an eager serialization for remote rpc invocation messages.
    That way it is possible to check whether the message is serializable and
    whether it exceeds the maximum allowed akka frame size. If either of these
    constraints is violated, a proper exception is thrown instead of simply
    swallowing the exception as Akka does it.

----


> Check parameters for serializability before sending a remote RpcInvocation message
> ----------------------------------------------------------------------------------
>
>                 Key: FLINK-4383
>                 URL: https://issues.apache.org/jira/browse/FLINK-4383
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>
> Before sending a remote {{RpcInvocation}} message we should check that the rpc arguments
are serializable. If not we should eagerly fail with an appropriate exception message.
> If we don't do this, then Akka will silently fail serializing the message without telling
the user.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message