flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4366) Enforce parallelism=1 For AllWindowedStream
Date Thu, 11 Aug 2016 08:17:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15416731#comment-15416731
] 

ASF GitHub Bot commented on FLINK-4366:
---------------------------------------

GitHub user wuchong opened a pull request:

    https://github.com/apache/flink/pull/2354

    [FLINK-4366] Enforce parallelism=1 For AllWindowedStream

    Thanks for contributing to Apache Flink. Before you open your pull request, please take
the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request.
For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your
changes.
    
    - [x] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [x] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    
    This PR avoid users try to set a parallelism on an all-windowed stream. 
    
    I add an `isAllWindow` field to mark a transformation is  all-windowed. I'm appreciate
if there is better solutions. 


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wuchong/flink FLINK-4366

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2354.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2354
    
----
commit 79ac99a715ef9bf15de0e5f0cd8080ebc8d278c6
Author: Jark Wu <wuchong.wc@alibaba-inc.com>
Date:   2016-08-11T08:04:54Z

    [FLINK-4366] Enforce parallelism=1 For AllWindowedStream

----


> Enforce parallelism=1 For AllWindowedStream
> -------------------------------------------
>
>                 Key: FLINK-4366
>                 URL: https://issues.apache.org/jira/browse/FLINK-4366
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Aljoscha Krettek
>            Assignee: Jark Wu
>
> Right now, it is possible to use {{DataStream.windowAll/timeWindowAll}} and then set
a different parallelism afterwards. Flink will silently accept this and spawn the number of
parallel operators, only one instance of those will do all the processing, though, since the
elements are implicitly keyed by a dummy key.
> We should throw an exception if users try to set a parallelism on an all-windowed stream.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message