flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4363) Implement TaskManager basic startup of all components in java
Date Wed, 24 Aug 2016 03:59:21 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15434147#comment-15434147
] 

ASF GitHub Bot commented on FLINK-4363:
---------------------------------------

Github user wangzhijiang999 commented on the issue:

    https://github.com/apache/flink/pull/2400
  
    Hi @mxm , I pushed some modifications based on your comments, including:
    1. Make var as final
    2. Implement TaskExecutorConfiguration class in java instead of TaskManagerConfiguration
in scala, the NetworkEnvironmentConfiguration should also be rewrote by java, but it will
cause import mistake in NetworkEnvironment, so retain the current implementation.
    3. Replace scala tuple2<hostname, port> by InetAddress, and the scala tuple4 by
org.apache.flink.api.java.tuple.Tuple4
    4. Remove throws in checkConfigParameter method
    5. There are two public static methods  "selectNetworkInterfaceAndRunTaskManager" and
"startTaskManagerComponentsAndActor" that can be invoked by outside world. For startTaskManagerComponentsAndActor
method, the parameters should pass "RPCService" and  "HighAvailabilityServices" for constructing
"TaskExecutor" directly. For "startTaskManagerComponentsAndActor" method, we will generate
the default "RPCService" and "HighAvailabilityServices" or based on configuration. 
    6. Fix the missing ResourceID parameter description.
    
    Thank you for further suggestions!


> Implement TaskManager basic startup of all components in java
> -------------------------------------------------------------
>
>                 Key: FLINK-4363
>                 URL: https://issues.apache.org/jira/browse/FLINK-4363
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Cluster Management
>            Reporter: Zhijiang Wang
>            Assignee: Zhijiang Wang
>
> Similar with current {{TaskManager}},but implement initialization and startup all components
in java instead of scala.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message