flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4362) Auto generate message sender classes via Java Proxies
Date Fri, 12 Aug 2016 08:07:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15418497#comment-15418497
] 

ASF GitHub Bot commented on FLINK-4362:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2357#discussion_r74554448
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rpc/RpcEndpoint.java ---
    @@ -172,6 +173,13 @@ public void runAsync(Runnable runnable) {
     		return ((MainThreadExecutor) self).callAsync(callable, timeout);
     	}
     
    +	/**
    +	 * Returns the class of the self gateway type.
    +	 *
    +	 * @return Class of the self gateway type
    +	 */
    +	public abstract Class<C> getSelfGatewayType();
    --- End diff --
    
    Yes we can do this. I thought about this and then went for the solution which saves some
compute cycles. I can change it to the reflection alternative if it's pre-mature optimization.


> Auto generate message sender classes via Java Proxies
> -----------------------------------------------------
>
>                 Key: FLINK-4362
>                 URL: https://issues.apache.org/jira/browse/FLINK-4362
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>            Reporter: Stephan Ewen
>            Assignee: Till Rohrmann
>
> The first version of the RPC service needs to manually create the sender classes, which
turn method calls into messages.
> This can be automated by using Java Proxies.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message