flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4348) Implement communication from ResourceManager to TaskManager
Date Tue, 23 Aug 2016 01:33:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431947#comment-15431947
] 

ASF GitHub Bot commented on FLINK-4348:
---------------------------------------

Github user beyond1920 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2389#discussion_r75790203
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rpc/resourcemanager/ResourceManagerToTaskExecutorHeartbeatScheduler.java
---
    @@ -0,0 +1,242 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.rpc.resourcemanager;
    +
    +import akka.dispatch.OnFailure;
    +import akka.dispatch.OnSuccess;
    +import org.apache.flink.runtime.clusterframework.types.ResourceID;
    +import org.apache.flink.runtime.rpc.taskexecutor.SlotReport;
    +import org.apache.flink.runtime.rpc.taskexecutor.TaskExecutorGateway;
    +import org.slf4j.Logger;
    +import scala.concurrent.Future;
    +import scala.concurrent.duration.FiniteDuration;
    +
    +import java.util.UUID;
    +import java.util.concurrent.TimeUnit;
    +import java.util.concurrent.TimeoutException;
    +
    +import static org.apache.flink.util.Preconditions.checkState;
    +
    +/**
    + * heartbeat between ResourceManager and TaskManager, it is responsible for schedule
heartbeat and handle
    + * heartbeat lost cases
    + */
    +public class ResourceManagerToTaskExecutorHeartbeatScheduler {
    +
    +	/** default heartbeat interval time in millisecond */
    +	private static final long INITIAL_HEARTBEAT_INTERVAL_MILLIS = 5000;
    +
    +	/** default heartbeat timeout in millisecond */
    +	private static final long INITIAL_HEARTBEAT_TIMEOUT_MILLIS = 200;
    +
    +	/** max heartbeat interval time in millisecond (which is used in retry heartbeat case)
*/
    +	private static final long MAX_HEARTBEAT_TIMEOUT_MILLIS = 30000;
    +
    +	/** if a failure except for timeout exception happened when trigger heartbeat from resourceManager
to taskManager , next attemp will start after  ERROR_HEARTBEAT_DELAY_MILLIS millisecond */
    --- End diff --
    
    good idea


> Implement communication from ResourceManager to TaskManager
> -----------------------------------------------------------
>
>                 Key: FLINK-4348
>                 URL: https://issues.apache.org/jira/browse/FLINK-4348
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Cluster Management
>            Reporter: Kurt Young
>            Assignee: zhangjing
>
> There are mainly 3 logics initiated from RM to TM:
> * Heartbeat, RM use heartbeat to sync with TM's slot status
> * SlotRequest, when RM decides to assign slot to JM, should first try to send request
to TM for slot. TM can either accept or reject this request.
> * FailureNotify, in some corner cases, TM will be marked as invalid by cluster manager
master(e.g. yarn master), but TM itself does not realize. RM should send failure notify to
TM and TM can terminate itself



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message