flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4342) Fix dependencies of flink-connector-filesystem
Date Tue, 09 Aug 2016 20:53:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15414219#comment-15414219
] 

ASF GitHub Bot commented on FLINK-4342:
---------------------------------------

GitHub user StephanEwen opened a pull request:

    https://github.com/apache/flink/pull/2346

    [FLINK-4342] [build] Fix dependencies of flink-connector-filesystem

    This fixes dependencies of the `flink-connector-filesystem` project
    
      - Remove unneeded Guava dependency
      - Set hadoop-shaded-artifact dependency to 'provided' as in other connectors, because
the dependency should not go into the user's jar.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/StephanEwen/incubator-flink fix_filesystem_dependencies

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2346.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2346
    
----
commit 097c13833a7f643f6c665c66bae5e7db6ad57ea7
Author: Stephan Ewen <sewen@apache.org>
Date:   2016-08-09T20:49:55Z

    [FLINK-4342] [build] Fix dependencies of flink-connector-filesystem
    
      - Remove unneeded Guava dependency
      - Set hadoop-shaded-artifact dependency to 'provided'

----


> Fix dependencies of flink-connector-filesystem
> ----------------------------------------------
>
>                 Key: FLINK-4342
>                 URL: https://issues.apache.org/jira/browse/FLINK-4342
>             Project: Flink
>          Issue Type: Bug
>          Components: Streaming Connectors
>    Affects Versions: 1.1.0
>            Reporter: Stephan Ewen
>            Assignee: Stephan Ewen
>             Fix For: 1.2.0
>
>
> The {{flink-connector-filesystem}} has inconsistent dependencies
>   - The Guava dependency is unused and can be removed
>   - The hadoop-shaded dependency is in 'compile' scope, but should be in 'provided' scope,
because it must not go into the user code jar.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message