flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4281) Wrap all Calcite Exceptions in Flink Exceptions
Date Mon, 15 Aug 2016 06:17:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15420648#comment-15420648
] 

ASF GitHub Bot commented on FLINK-4281:
---------------------------------------

Github user mushketyk commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2372#discussion_r74723604
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/FlinkPlannerImpl.scala
---
    @@ -85,23 +89,27 @@ class FlinkPlannerImpl(
         }
         catch {
           case e: RuntimeException =>
    -        throw new CValidationException(e)
    +        throw ValidationException(e.getMessage)
         }
         validatedSqlNode
       }
     
    -  @throws(classOf[RelConversionException])
    +  @throws(classOf[FlinkRelConversionException])
    --- End diff --
    
    Same as above.


> Wrap all Calcite Exceptions in Flink Exceptions
> -----------------------------------------------
>
>                 Key: FLINK-4281
>                 URL: https://issues.apache.org/jira/browse/FLINK-4281
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.2.0
>            Reporter: Timo Walther
>            Assignee: Jark Wu
>
> Some exceptions are already wrapped in Flink exceptions but there are still exceptions
thrown by Calcite. I would propose that all Exceptions thrown by the Table API are Flink's
Exceptions, esp. the FlinkPlannerImpl exceptions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message