flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4273) Refactor JobClientActor to watch already submitted jobs
Date Mon, 22 Aug 2016 10:00:28 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15430483#comment-15430483
] 

ASF GitHub Bot commented on FLINK-4273:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2313#discussion_r75650141
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java ---
    @@ -275,9 +275,35 @@ public static ClassLoader retrieveClassLoader(
     	public static JobExecutionResult awaitJobResult(JobListeningContext listeningContext)
throws JobExecutionException {
     
     		final JobID jobID = listeningContext.jobID;
    +		final ActorRef jobClientActor = listeningContext.jobClientActor;
     		final Future<Object> jobSubmissionFuture = listeningContext.jobResultFuture;
     		final ClassLoader classLoader = listeningContext.classLoader;
     
    +		while (!jobSubmissionFuture.isCompleted()) {
    +			try {
    +				Thread.sleep(250);
    +			} catch (InterruptedException e) {
    +				throw new JobExecutionException(jobID, "Interrupted while waiting for execution result.",
e);
    +			}
    +
    +			try {
    +				Await.result(
    +					Patterns.ask(
    +						jobClientActor,
    +						JobClientMessages.getPing(),
    --- End diff --
    
    Sure, we can do that.


> Refactor JobClientActor to watch already submitted jobs 
> --------------------------------------------------------
>
>                 Key: FLINK-4273
>                 URL: https://issues.apache.org/jira/browse/FLINK-4273
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Client
>            Reporter: Maximilian Michels
>            Assignee: Maximilian Michels
>            Priority: Minor
>             Fix For: 1.2.0
>
>
> The JobClientActor assumes that it receives a job, submits it, and waits for the result.
This process should be broken up into a submission process and a waiting process which can
both be entered independently. This leads to two different entry points:
> 1) submit(job) -> wait
> 2) retrieve(jobID) -> wait



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message