flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4253) Rename "recovery.mode" config key to "high-availability"
Date Tue, 09 Aug 2016 09:22:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15413258#comment-15413258
] 

ASF GitHub Bot commented on FLINK-4253:
---------------------------------------

GitHub user ramkrish86 opened a pull request:

    https://github.com/apache/flink/pull/2342

    FLINK-4253 - Rename "recovery.mode" config key to "high-availability" (Ram)

    Thanks for contributing to Apache Flink. Before you open your pull request, please take
the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request.
For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your
changes.
    
    - [ ] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [ ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    
    I ran `mvn clean verify` - all the tests in flink-runtime passed and this test failed

    `
    Failed tests:
      BlobServerDeleteTest.testDeleteAll:157 DELETE operation failed: Server side error: Unable
to delete directory C:\Users\rsvasude\AppData\Local\Temp\blobStore-18502f30-ee19-4c4c-9cb7-7b51c9bdeffb\job_801e21ed42b26de3c813cfe4917d029d.
      LeaderChangeStateCleanupTest.testReelectionOfSameJobManager:244 TaskManager should not
be able to register at JobManager.
    `
    I think it is an environment issue. Ran other tests changed as part of this PR and they
all seems to pass.
    Handled backward compatability if the config file has the older config `recover.mode`.
The same has been handled in the `config.sh` script also. 
    
    Suggestions/feedback welcome. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ramkrish86/flink FLINK-4253

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2342.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2342
    
----
commit 0acc3c4ae131bcd8735493227f1f3df18adae1b3
Author: Ramkrishna <ramkrishna.s.vasudevan@intel.com>
Date:   2016-08-09T09:18:12Z

    FLINK-4253 - Rename "recovery.mode" config key to "high-availability"
    (Ram)

----


> Rename "recovery.mode" config key to "high-availability"
> --------------------------------------------------------
>
>                 Key: FLINK-4253
>                 URL: https://issues.apache.org/jira/browse/FLINK-4253
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Ufuk Celebi
>            Assignee: ramkrishna.s.vasudevan
>
> Currently, HA is configured via the following configuration keys:
> {code}
> recovery.mode: STANDALONE // No high availability (HA)
> recovery.mode: ZOOKEEPER // HA
> {code}
> This could be more straight forward by simply renaming the key to {{high-availability}}.
Furthermore, the term {{STANDALONE}} is overloaded. We already have standalone cluster mode.
> {code}
> high-availability: NONE // No HA
> high-availability: ZOOKEEPER // HA via ZooKeeper
> {code}
> The {{recovery.mode}} configuration keys would have to be deprecated before completely
removing them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message