flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4148) incorrect calculation distance in QuadTree
Date Wed, 31 Aug 2016 14:06:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15452331#comment-15452331

ASF GitHub Bot commented on FLINK-4148:

GitHub user xhumanoid opened a pull request:


    [FLINK-4148]  incorrect calculation minDist distance in QuadTree

    Thanks for contributing to Apache Flink. Before you open your pull request, please take
the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request.
For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your
    - [ ] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    - [ ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xhumanoid/flink master

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2442
commit 4291a9ac78ec2bb989ffce4bbfd43e58b7d7b3b9
Author: Alexey Diomin <diominay@gmail.com>
Date:   2016-07-04T15:13:11Z

    [FLINK-4148]  incorrect calculation minDist distance in QuadTree


> incorrect calculation distance in QuadTree
> ------------------------------------------
>                 Key: FLINK-4148
>                 URL: https://issues.apache.org/jira/browse/FLINK-4148
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Alexey Diomin
>            Priority: Trivial
>         Attachments: 0001-FLINK-4148-incorrect-calculation-minDist-distance-in.patch
> https://github.com/apache/flink/blob/master/flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala#L105
> Because EuclideanDistanceMetric extends SquaredEuclideanDistanceMetric we always move
in first case and never reach case for math.sqrt(minDist)
> correct match first EuclideanDistanceMetric and after it SquaredEuclideanDistanceMetric
> p.s. because EuclideanDistanceMetric more compute expensive and stay as default DistanceMetric
it's can cause some performance degradation for KNN on default parameters

This message was sent by Atlassian JIRA

View raw message