flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4094) Off heap memory deallocation might not properly work
Date Fri, 05 Aug 2016 05:57:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15408925#comment-15408925
] 

ASF GitHub Bot commented on FLINK-4094:
---------------------------------------

GitHub user ramkrish86 opened a pull request:

    https://github.com/apache/flink/pull/2336

    FLINK-4094 Off heap memory deallocation might not properly work (Ram)

    Thanks for contributing to Apache Flink. Before you open your pull request, please take
the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request.
For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your
changes.
    
    - [ ] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [ ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    
    Just added a log msg warning the user about using OFFHEAP and PREALLOCATION together.
Same comment is added over in the doc also. But not sure if that is enough or we need more
information to be added there. But for a user it may not be relevant. Any thoughts?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ramkrish86/flink FLINK-4094

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2336.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2336
    
----
commit 4e51aaffebeb3ccf530bff9e67c1acd63d90672d
Author: Ramkrishna <ramkrishna.s.vasudevan@intel.com>
Date:   2016-08-05T05:55:07Z

    FLINK-4094 Off heap memory deallocation might not properly work (Ram)

----


> Off heap memory deallocation might not properly work
> ----------------------------------------------------
>
>                 Key: FLINK-4094
>                 URL: https://issues.apache.org/jira/browse/FLINK-4094
>             Project: Flink
>          Issue Type: Bug
>          Components: Local Runtime
>    Affects Versions: 1.1.0
>            Reporter: Till Rohrmann
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Critical
>             Fix For: 1.1.0
>
>
> A user reported that off-heap memory is not properly deallocated when setting {{taskmanager.memory.preallocate:false}}
(per default) [1]. This can cause the TaskManager process being killed by the OS.
> It should be possible to execute multiple batch jobs with preallocation turned off. No
longer used direct memory buffers should be properly garbage collected so that the JVM process
does not exceed it's maximum memory bounds.
> [1] http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/offheap-memory-allocation-and-memory-leak-bug-td12154.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message