flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4081) FieldParsers should support empty strings
Date Mon, 08 Aug 2016 12:41:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411745#comment-15411745
] 

ASF GitHub Bot commented on FLINK-4081:
---------------------------------------

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/2297
  
    Okay, I think the main source of confusion here is that `EMPTY_STRING` does actually not
refer to an empty string (as specific to the string parser) but to something like "null",
"empty column", or "missing value".
    
    Let's call it something like that and then it actually makes sense to me to communicate
that via an error state. Because it is actually not a regular value (as an empty string would
be).



> FieldParsers should support empty strings
> -----------------------------------------
>
>                 Key: FLINK-4081
>                 URL: https://issues.apache.org/jira/browse/FLINK-4081
>             Project: Flink
>          Issue Type: Bug
>          Components: Core
>            Reporter: Flavio Pompermaier
>            Assignee: Timo Walther
>              Labels: csvparser, table-api
>
> In order to parse CSV files using the new Table API that converts rows to Row objects
(that support null values), FiledParser implementations should support emptry strings setting
the parser state to ParseErrorState.EMPTY_STRING (for example FloatParser and DoubleParser
doesn't respect this constraint)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message