flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3702) DataStream API PojoFieldAccessor doesn't support nested POJOs
Date Tue, 23 Aug 2016 10:04:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15432557#comment-15432557
] 

ASF GitHub Bot commented on FLINK-3702:
---------------------------------------

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2094#discussion_r75836333
  
    --- Diff: flink-scala/src/main/java/org/apache/flink/api/scala/typeutils/ProductFieldAccessor.java
---
    @@ -0,0 +1,63 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.api.scala.typeutils;
    +
    +import org.apache.flink.api.common.ExecutionConfig;
    +import org.apache.flink.api.common.typeinfo.TypeInformation;
    +import org.apache.flink.api.java.typeutils.FieldAccessor;
    +import org.apache.flink.api.java.typeutils.TupleTypeInfoBase;
    +import org.apache.flink.api.java.typeutils.runtime.TupleSerializerBase;
    +import scala.Product;
    +
    +public final class ProductFieldAccessor<T, R, F> extends FieldAccessor<T, F>
{
    +
    +	private static final long serialVersionUID = 1L;
    +
    +	private final int pos;
    +	private final TupleSerializerBase<T> serializer;
    +	private final Object[] fields;
    +	private final int length;
    +	private final FieldAccessor<R, F> innerAccessor;
    +
    +	ProductFieldAccessor(int pos, TypeInformation<T> typeInfo, FieldAccessor<R,
F> innerAccessor, ExecutionConfig config) {
    +		this.pos = pos;
    --- End diff --
    
    As I said above, some checking of parameters would not harm.


> DataStream API PojoFieldAccessor doesn't support nested POJOs
> -------------------------------------------------------------
>
>                 Key: FLINK-3702
>                 URL: https://issues.apache.org/jira/browse/FLINK-3702
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataStream API
>    Affects Versions: 1.0.0
>            Reporter: Robert Metzger
>            Assignee: Gabor Gevay
>
> The {{PojoFieldAccessor}} (which is used by {{.sum(String)}} and similar methods) doesn't
support nested POJOs right now.
> As part of FLINK-3697 I'll add a check for a nested POJO and fail with an exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message