flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3042) Define a way to let types create their own TypeInformation
Date Wed, 17 Aug 2016 10:19:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15424256#comment-15424256
] 

ASF GitHub Bot commented on FLINK-3042:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2337#discussion_r75097072
  
    --- Diff: flink-core/src/test/java/org/apache/flink/api/java/typeutils/TypeInfoFactoryTest.java
---
    @@ -0,0 +1,482 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.api.java.typeutils;
    +
    +import java.lang.reflect.Type;
    +import java.util.HashMap;
    +import java.util.Map;
    +import org.apache.flink.api.common.ExecutionConfig;
    +import org.apache.flink.api.common.functions.InvalidTypesException;
    +import org.apache.flink.api.common.functions.MapFunction;
    +import static org.apache.flink.api.common.typeinfo.BasicTypeInfo.BOOLEAN_TYPE_INFO;
    +import static org.apache.flink.api.common.typeinfo.BasicTypeInfo.DOUBLE_TYPE_INFO;
    +import static org.apache.flink.api.common.typeinfo.BasicTypeInfo.FLOAT_TYPE_INFO;
    +import static org.apache.flink.api.common.typeinfo.BasicTypeInfo.INT_TYPE_INFO;
    +import static org.apache.flink.api.common.typeinfo.BasicTypeInfo.STRING_TYPE_INFO;
    +import org.apache.flink.api.common.typeinfo.TypeInfo;
    +import org.apache.flink.api.common.typeinfo.TypeInfoFactory;
    +import org.apache.flink.api.common.typeinfo.TypeInformation;
    +import org.apache.flink.api.common.typeutils.TypeSerializer;
    +import org.apache.flink.api.java.tuple.Tuple1;
    +import org.apache.flink.api.java.tuple.Tuple2;
    +import static org.junit.Assert.assertEquals;
    +import static org.junit.Assert.assertTrue;
    +import org.junit.Test;
    +
    +/**
    + * Tests for extracting {@link org.apache.flink.api.common.typeinfo.TypeInformation}
from types
    + * using a {@link org.apache.flink.api.common.typeinfo.TypeInfoFactory}
    + */
    +@SuppressWarnings({"unchecked", "rawtypes"})
    +public class TypeInfoFactoryTest {
    +
    +	@Test
    +	public void testSimpleType() {
    +		TypeInformation ti = TypeExtractor.createTypeInfo(IntLike.class);
    --- End diff --
    
    I would prefer to not use raw types unless really necessary. Can't you use `TypeInformation<?>`?


> Define a way to let types create their own TypeInformation
> ----------------------------------------------------------
>
>                 Key: FLINK-3042
>                 URL: https://issues.apache.org/jira/browse/FLINK-3042
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.10.0
>            Reporter: Stephan Ewen
>            Assignee: Timo Walther
>             Fix For: 1.0.0
>
>
> Currently, introducing new Types that should have specific TypeInformation requires
>   - Either integration with the TypeExtractor
>   - Or manually constructing the TypeInformation (potentially at every place) and using
type hints everywhere.
> I propose to add a way to allow classes to create their own TypeInformation (like a static
method "createTypeInfo()").
> To support generic nested types (like Optional / Either), the type extractor would provide
a Map of what generic variables map to what types (deduced from the input). The class can
use that to create the correct nested TypeInformation (possibly by calling the TypeExtractor
again, passing the Map of generic bindings).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message