flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From beyond1920 <...@git.apache.org>
Subject [GitHub] flink pull request #2435: [FLINK-4478] [flip-6] Add HeartbeatManager
Date Wed, 31 Aug 2016 06:18:10 GMT
Github user beyond1920 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2435#discussion_r76929812
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/HeartbeatListener.java
---
    @@ -0,0 +1,61 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.heartbeat;
    +
    +import org.apache.flink.runtime.clusterframework.types.ResourceID;
    +import scala.concurrent.Future;
    +
    +/**
    + * Interface for the interaction with the {@link HeartbeatManager}. The heartbeat listener
is used
    + * for the following things:
    + * <p>
    + * <ul>
    + *     <il>Notifications about heartbeat timeouts</il>
    + *     <li>Payload reports of incoming heartbeats</li>
    + *     <li>Retrieval of payloads for outgoing heartbeats</li>
    + * </ul>
    + * @param <I> Type of the incoming payload
    + * @param <O> Type of the outgoing payload
    + */
    +public interface HeartbeatListener<I, O> {
    +
    +	/**
    +	 * Callback which is called if a heartbeat for the machine identified by the given resource
    +	 * ID times out.
    +	 *
    +	 * @param resourceID Resource ID of the machine whose heartbeat has timed out
    +	 */
    +	void notifyHeartbeatTimeout(ResourceID resourceID);
    +
    +	/**
    +	 * Callback which is called whenever a heartbeat with an associated payload is received.
The
    +	 * carried payload is given to this method.
    +	 *
    +	 * @param payload Payload of the received heartbeat
    +	 */
    +	void reportPayload(I payload);
    --- End diff --
    
    maybe we should add ResourceID param to identify which sender send this incoming message


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message