flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink issue #2400: [FLINK-4363] Implement TaskManager basic startup of all c...
Date Tue, 30 Aug 2016 13:42:03 GMT
Github user mxm commented on the issue:

    https://github.com/apache/flink/pull/2400
  
    Could you please remove the merge commits from this PR? We don't use merge commits in
the Flink repository to have an easy to read code history. Thank you.
    
    Thanks for opening FLINK-4505. For now, let us focus on implementing the factory to bring
up the TaskExecutor for testing with the FlinkMiniCluster. I think it would be nice to remove
as much startup code from the TaskExecutor class as possible. Any code which can be shared
among all `TaskExecutorFactory`s can be put in the abstract `TaskExecutorFactoryBase` class.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message