flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink issue #2244: [FLINK-3874] Add a Kafka TableSink with JSON serializatio...
Date Thu, 25 Aug 2016 16:35:58 GMT
Github user fhueske commented on the issue:

    Looks good to merge @mushketyk :-)
    The only thing that I'd change would be to rename `Kafka08JsonTableSinkTest` to `Kafka08JsonTableSinkITCase`
(same for Kafka09*), since these are long running integration tests which should be executed
in the appropriate Maven phase (verify). 
    I can do that as well before merging. 
    Thanks, Fabian

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message