flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request #2405: [FLINK-4451] [rpc] Throw RpcConnectionException wh...
Date Tue, 23 Aug 2016 16:48:54 GMT
Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2405#discussion_r75905953
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rpc/registration/RetryingRegistration.java
---
    @@ -197,7 +197,7 @@ public void onSuccess(Gateway result) {
     				@Override
     				public void onFailure(Throwable failure) {
     					if (!isCanceled()) {
    -						log.warn("Could not resolve {} address {}, retrying...", targetName, targetAddress);
    +						log.warn("Could not resolve {} address {}, retrying...", targetName, targetAddress,
failure);
    --- End diff --
    
    I think you cannot mix argument markers and exception logging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message