flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From beyond1920 <...@git.apache.org>
Subject [GitHub] flink pull request #2389: [FLINK-4348] [cluster management] Implement commun...
Date Tue, 23 Aug 2016 01:25:57 GMT
Github user beyond1920 commented on a diff in the pull request:

    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rpc/resourcemanager/ResourceManager.java
    @@ -52,18 +61,45 @@
     public class ResourceManager extends RpcEndpoint<ResourceManagerGateway> {
     	private final ExecutionContext executionContext;
     	private final Map<JobMasterGateway, InstanceID> jobMasterGateways;
    +	private final Map<ResourceID, TaskExecutorGateway> taskExecutorGateways;
    +	private final Map<ResourceID, ResourceManagerToTaskExecutorHeartbeatScheduler>
    +	private final LeaderElectionService leaderElectionService;
    +	private UUID leaderSessionID;
    +	// TODO private final SlotManager slotManager;
    -	public ResourceManager(RpcService rpcService, ExecutorService executorService) {
    +	public ResourceManager(RpcService rpcService, ExecutorService executorService, LeaderElectionService
leaderElectionService) {
    --- End diff --
    Cool. maybe i could add a method like "LeaderElectionService getResourceManagerLeaderElectionService()
throws Exception; " in HighAvailabilityServices class?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message