flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #2389: [FLINK-4348] [cluster management] Implement commun...
Date Mon, 22 Aug 2016 13:00:29 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2389#discussion_r75672201
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/SlotReport.java
---
    @@ -18,21 +18,38 @@
     
     package org.apache.flink.runtime.rpc.taskexecutor;
     
    +import org.apache.flink.runtime.clusterframework.types.ResourceID;
    +
     import java.io.Serializable;
    +import java.util.List;
     
     /**
      * A report about the current status of all slots of the TaskExecutor, describing
      * which slots are available and allocated, and what jobs (JobManagers) the allocated
slots
      * have been allocated to.
      */
    -public class SlotReport implements Serializable{
    +public class SlotReport implements Serializable {
    +
    +	private static final long serialVersionUID = -3150175198722481689L;
    +
    +	/** the status of all slots of the TaskManager */
    +	private final List<SlotStatus> slotsStatus;
     
    -	private static final long serialVersionUID = 1L;
    +	// resourceID identify the taskExecutor
    --- End diff --
    
    I know we're not overly consistent with that but field descriptions use normally the multi-line
comment style `/** .... */`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message