flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wangzhijiang999 <...@git.apache.org>
Subject [GitHub] flink pull request #2400: [FLINK-4363] Implement TaskManager basic startup o...
Date Mon, 22 Aug 2016 10:17:27 GMT
Github user wangzhijiang999 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2400#discussion_r75652404
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutor.java
---
    @@ -35,27 +79,634 @@
      */
     public class TaskExecutor extends RpcEndpoint<TaskExecutorGateway> {
     
    -	/** The unique resource ID of this TaskExecutor */
    +	private static final Logger LOG = LoggerFactory.getLogger(TaskExecutor.class);
    +
    +	/** Return code for critical errors during the runtime */
    +	private static final int RUNTIME_FAILURE_RETURN_CODE = 2;
    +
    +	/** The name of the TaskManager actor */
    +	private static final String TASK_MANAGER_NAME = "taskmanager";
    --- End diff --
    
    Yes, the initial reason for this is that all the inner names still called "TaskManager",
so the TaskExecutor class name can easily be be renamed to "TaskManager" to replace it in
final. Otherwise we should replace all the "taskexecutor" into "taskmanager" after final replace.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message