flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #2313: [FLINK-4273] Modify JobClient to attach to running...
Date Mon, 22 Aug 2016 09:28:57 GMT
Github user tillrohrmann commented on a diff in the pull request:

    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java ---
    @@ -275,9 +275,35 @@ public static ClassLoader retrieveClassLoader(
     	public static JobExecutionResult awaitJobResult(JobListeningContext listeningContext)
throws JobExecutionException {
     		final JobID jobID = listeningContext.jobID;
    +		final ActorRef jobClientActor = listeningContext.jobClientActor;
     		final Future<Object> jobSubmissionFuture = listeningContext.jobResultFuture;
     		final ClassLoader classLoader = listeningContext.classLoader;
    +		while (!jobSubmissionFuture.isCompleted()) {
    +			try {
    +				Thread.sleep(250);
    --- End diff --
    Can't we wait on the `jobSubmissionFuture` for, e.g., Flink's ask timeout and recover
timeout exceptions by sending an `Identify` message to the JobClient actor. If he replies
in time, then re-wait for the `jobSubmissionFuture`.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message