flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aljoscha <...@git.apache.org>
Subject [GitHub] flink issue #2350: [FLINK-4329] Fix Streaming File Source Timestamps/Waterma...
Date Fri, 19 Aug 2016 14:17:14 GMT
Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/2350
  
    I made one inline comments about moving the `SourceContext` and the instantiation code.
    
    Also, the problem with the "async exception check" can be solved by introducing an interface
`AsyncExceptionChecker` that is passed to the context. (I think that's what @rmetzger was
hinting at.)
    
    Even better yet, we might be able to get rid of that stuff by using `task.failExternally()`
in all places that previously made these async checks necessary. (The file read operator already
uses that, btw) 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message