flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #2363: [FLINK-4389] Expose metrics to WebFrontend
Date Fri, 19 Aug 2016 12:47:34 GMT
Github user tillrohrmann commented on a diff in the pull request:

    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/TaskManagerJobMetricGroup.java
    @@ -61,9 +58,7 @@ public TaskManagerJobMetricGroup(
     			JobID jobId,
     			@Nullable String jobName) {
    -		super(registry, jobId, jobName, scopeFormat.formatScope(parent, jobId, jobName));
    -		this.parent = checkNotNull(parent);
    +		super(registry, checkNotNull(parent), jobId, jobName, scopeFormat.formatScope(parent,
jobId, jobName));
    --- End diff --
    Why do you do them at all if you want to save them in the first place?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message