flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #2363: [FLINK-4389] Expose metrics to WebFrontend
Date Thu, 18 Aug 2016 17:56:43 GMT
Github user zentol commented on a diff in the pull request:

    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/ComponentMetricGroup.java
    @@ -33,19 +36,42 @@
      * group could for example include the task attempt number (more fine grained identification),
      * exclude it (for continuity of the namespace across failure and recovery).
    -public abstract class ComponentMetricGroup extends AbstractMetricGroup {
    +public abstract class ComponentMetricGroup<P extends AbstractMetricGroup> extends
AbstractMetricGroup<P> {
    --- End diff --
    I'm not sure what you mean, but `JobMetricGroup` inherits from `ComponentMetricGroup`.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message