flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #2272: [FLINK-4231] [java] Switch DistinctOperator from G...
Date Thu, 18 Aug 2016 16:10:40 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2272#discussion_r75338445
  
    --- Diff: flink-optimizer/src/test/java/org/apache/flink/optimizer/DistinctCompilationTest.java
---
    @@ -71,8 +71,8 @@ public void testDistinctPlain() {
     			assertEquals(reduceNode, sinkNode.getInput().getSource());
     
     			// check that both reduce and combiner have the same strategy
    -			assertEquals(DriverStrategy.SORTED_GROUP_REDUCE, reduceNode.getDriverStrategy());
    -			assertEquals(DriverStrategy.SORTED_GROUP_COMBINE, combineNode.getDriverStrategy());
    +			assertEquals(DriverStrategy.SORTED_REDUCE, reduceNode.getDriverStrategy());
    +			assertEquals(DriverStrategy.SORTED_PARTIAL_REDUCE, combineNode.getDriverStrategy());
    --- End diff --
    
    Add a test that sets a `CombineHint.HASH` and check that the `combineNode` driver strategy
is `HASHED_PARTIAL_REDUCE`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message